Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update var ${workspaceRoot} to ${workspaceFolder} #34269

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Update var ${workspaceRoot} to ${workspaceFolder} #34269

merged 1 commit into from
Sep 16, 2021

Conversation

shivapoudel
Copy link
Contributor

Description

Ref: https://code.visualstudio.com/docs/editor/variables-reference#_why-isnt-workspaceroot-documented

How has this been tested?

Starting with wp-env start --xdebug and tested with VSCode PHP debug lunch config.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@shivapoudel shivapoudel changed the title Update var ${workspaceRoot} to ${workspaceRoot} Update var ${workspaceRoot} to ${workspaceFolder} Aug 24, 2021
@annezazu annezazu added the [Type] Enhancement A suggestion for improvement. label Aug 25, 2021
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shivapoudel, thank you for updating workspaceRoot to workspaceFolder 👍 The change seems good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants